Adding ES|QL command URI_PARTS#140004
Conversation
…esql-uri_parts-command
ℹ️ Important: Docs version tagging👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version. We use applies_to tags to mark version-specific features and changes. Expand for a quick overviewWhen to use applies_to tags:✅ At the page level to indicate which products/deployments the content applies to (mandatory) What NOT to do:❌ Don't remove or replace information that applies to an older version 🤔 Need help?
|
…esql-uri_parts-command
ivancea
left a comment
There was a problem hiding this comment.
LGTM! The only missing thing, the strict column validation in the test generator. The output should be the one we expect
I assume you mean doing what I did in my initial commit, is that correct? What do you propose? If there's an issue, do you think it may be related to my command? The problem is that neither Grok nor Dissect test this. On the contrary, their validation seems as if they expect that there are situations where their execution is not going to add output columns - they only assert that they do not remove columns 🤔 |
ivancea
left a comment
There was a problem hiding this comment.
LGTM, thanks for the TS and generative tests!
Closes #134885
This PR adds the new
URI_PARTScommand on top of an infrastructure for new type of commands that execute a single evaluation given a single input and produce a compound result. Since real compound column type is not supported (yet?), the evaluation results with multiple fields containing the same prefix. Hopefully, if and when we add support to compound (i.e. object-like) column type, it should be easy to change the type returned by such commands without making it a breaking change.Key characteristics
URI_PARTS <uri-parts> = <uri>To-do list